Changeset 1277Tweet

Timestamp:

Apr 23, 2012, 8:42:06 AM (11 years ago)

Author:

sam

Message:

orbital: fix normals in the case of non-uniform scaling.

File:

• trunk/orbital/mesh.h (modified) (1 diff)

trunk/orbital/mesh.h

@@ -447 +447 @@
     void Scale(vec3 const &s)
     {
-        /* FIXME: this code breaks normals! */
+        vec3 const invs = vec3(1) / s;
+
         for (int i = m_vert_cursor; i < m_vert.Count(); i++)
         {
             m_vert[i].m1 *= s;
-            m_vert[i].m2 *= s;
-        }
-
-        // BH : TODO : not sure about this one
-        // Sam: not too sure either!
+            m_vert[i].m2 = normalize(m_vert[i].m2 * invs);
+        }
+
+        /* Flip winding if the scaling involves mirroring */
         if (s.x * s.y * s.z < 0)
         {