Changeset 2309 for trunkTweet

Timestamp:

Feb 1, 2013, 2:28:08 AM (7 years ago)

Author:

sam

Message:

color: fix a logic error in RGBToHSL.

File:

• trunk/src/lol/image/color.h (modified) (1 diff)

trunk/src/lol/image/color.h

@@ -123 +123 @@
         float chroma = src.r - min(src.g, src.b);
         float luma = src.r + min(src.g, src.b);
+        /* XXX: we use min() here because numerical stability is not
+         * guaranteed with -ffast-math, I’ve seen it fail on i386. */
         float h = min(abs(K + (src.g - src.b) / (6.f * chroma)), 1.f);
-        float s = min(abs(chroma / (min(luma, 2.f - luma))), 1.f);
+        float s = clamp(chroma / (min(luma, 2.f - luma)), 0.f, 1.f);
         return vec3(h, s, 0.5f * luma);
     }