Changeset 2805Tweet

Timestamp:

Jul 18, 2013, 12:03:42 PM (5 years ago)

Author:

benlitz

Message:

shaders now cache attribute location once they have been retrieved for the first time.

File:

• trunk/src/gpu/shader.cpp (modified) (2 diffs)

trunk/src/gpu/shader.cpp

@@ -61 +61 @@
 #elif !defined __CELLOS_LV2__
     GLuint prog_id, vert_id, frag_id;
+        // Benlitz: using a simple array could be faster since there is never more than a few attribute locations to store
+        Map<String, GLint> attrib_locations;
 #else
     CGprogram vert_id, frag_id;
@@ -333 +335 @@
 #if defined USE_D3D9 || defined _XBOX
 #elif !defined __CELLOS_LV2__
-    GLint l = glGetAttribLocation(data->prog_id, attr);
-    if (l < 0)
-    {
-        Log::Warn("tried to query invalid attribute: %s\n", attr);
-        l = 0;
-    }
+        GLint l;
+        
+        if (!data->attrib_locations.TryGetValue(attr, l))
+        {
+                l = glGetAttribLocation(data->prog_id, attr);
+                if (l < 0)
+                {
+                        Log::Warn("tried to query invalid attribute: %s\n", attr);
+                        l = 0;
+                }
+                else
+                {
+                        data->attrib_locations[String(attr)] = l;
+                }
+        }
     ret.m_flags |= (uint64_t)(uint32_t)l << 32;
 #else