Changeset 1110Tweet

Timestamp:

Dec 11, 2011, 12:58:09 PM (11 years ago)

Author:

sam

Message:

core: prefix Entity members with m_ to avoid accidental shadowing.

Location:

trunk/src

Files:

• debug/quad.cpp (modified) (1 diff)
• debug/record.cpp (modified) (1 diff)
• debug/stats.cpp (modified) (1 diff)
• entity.cpp (modified) (4 diffs)
• entity.h (modified) (5 diffs)
• font.cpp (modified) (1 diff)
• platform/ps3/ps3input.cpp (modified) (1 diff)
• platform/sdl/sdlinput.cpp (modified) (1 diff)
• text.cpp (modified) (1 diff)
• ticker.cpp (modified) (11 diffs)
• tileset.cpp (modified) (1 diff)
• world.cpp (modified) (1 diff)

trunk/src/debug/quad.cpp

@@ -120 +120 @@
     data->time = RandF(10000.0f);
 
-    drawgroup = DRAWGROUP_HUD;
+    m_drawgroup = DRAWGROUP_HUD;
 }
 

trunk/src/debug/record.cpp

@@ -60 +60 @@
 #endif
 
-    drawgroup = DRAWGROUP_CAPTURE;
+    m_drawgroup = DRAWGROUP_CAPTURE;
 }
 

trunk/src/debug/stats.cpp

@@ -44 +44 @@
     data->fp = fopen(path, "w+");
 
-    gamegroup = GAMEGROUP_AFTER;
+    m_gamegroup = GAMEGROUP_AFTER;
 }
 

trunk/src/entity.cpp

@@ -25 +25 @@
 
 Entity::Entity() :
-    gamenext(0),
-    drawnext(0),
-    ref(0),
-    destroy(0)
+    m_gamenext(0),
+    m_drawnext(0),
+    m_ref(0),
+    m_destroy(0)
 {
 #if !LOL_RELEASE
-    state = STATE_IDLE;
+    m_tickstate = STATE_IDLE;
 #endif
-    gamegroup = GAMEGROUP_DEFAULT;
-    drawgroup = DRAWGROUP_DEFAULT;
+    m_gamegroup = GAMEGROUP_DEFAULT;
+    m_drawgroup = DRAWGROUP_DEFAULT;
     Ticker::Register(this);
 }
@@ -41 +41 @@
 {
 #if !LOL_RELEASE
-    if (!destroy)
+    if (!m_destroy)
         Log::Error("entity destructor called directly\n");
 #endif
@@ -54 +54 @@
 {
 #if !LOL_RELEASE
-    if (state != STATE_PRETICK_GAME)
+    if (m_tickstate != STATE_PRETICK_GAME)
         Log::Error("invalid entity game tick\n");
-    state = STATE_POSTTICK_GAME;
+    m_tickstate = STATE_POSTTICK_GAME;
 #endif
 }
@@ -63 +63 @@
 {
 #if !LOL_RELEASE
-    if (state != STATE_PRETICK_DRAW)
+    if (m_tickstate != STATE_PRETICK_DRAW)
         Log::Error("invalid entity draw tick\n");
-    state = STATE_POSTTICK_DRAW;
+    m_tickstate = STATE_POSTTICK_DRAW;
 #endif
 }

trunk/src/entity.h

@@ -37 +37 @@
 
     virtual char const *GetName();
-    inline int IsDestroying() { return destroy; }
+    inline int IsDestroying() { return m_destroy; }
 
     virtual void TickGame(float deltams);
@@ -50 +50 @@
         GAMEGROUP_END
     }
-    gamegroup;
+    m_gamegroup;
 
     enum
@@ -61 +61 @@
         DRAWGROUP_END
     }
-    drawgroup;
+    m_drawgroup;
 
     static int const GAMEGROUP_BEGIN = 0;
@@ -76 +76 @@
         STATE_POSTTICK_DRAW,
     }
-    state;
+    m_tickstate;
 #endif
 
@@ -86 +86 @@
     virtual uint32_t OnStateChanged(uint32_t newstate)
     {
-        return m_state = newstate;
+        return LOLm_state = newstate;
     }
 
-    uint32_t m_state;
+    uint32_t LOLm_state;
     // Emcee end
 
 private:
-    Entity *gamenext, *drawnext, *autonext;
-    int ref, autorelease, destroy;
+    Entity *m_gamenext, *m_drawnext, *m_autonext;
+    int m_ref, m_autorelease, m_destroy;
 };
 

trunk/src/font.cpp

@@ -50 +50 @@
     data->size = data->tileset->GetSize(0);
 
-    drawgroup = DRAWGROUP_BEFORE;
+    m_drawgroup = DRAWGROUP_BEFORE;
 }
 

trunk/src/platform/ps3/ps3input.cpp

@@ -78 +78 @@
     data->mousebuttons = ivec3(0, 0, 0);
 
-    gamegroup = GAMEGROUP_BEFORE;
+    m_gamegroup = GAMEGROUP_BEFORE;
 #endif
 }

trunk/src/platform/sdl/sdlinput.cpp

@@ -45 +45 @@
     SDL_Init(SDL_INIT_TIMER);
 
-    gamegroup = GAMEGROUP_BEFORE;
+    m_gamegroup = GAMEGROUP_BEFORE;
 #endif
 }

trunk/src/text.cpp

@@ -50 +50 @@
     data->pos = vec3(0, 0, 0);
 
-    drawgroup = DRAWGROUP_HUD;
+    m_drawgroup = DRAWGROUP_HUD;
 }
 

trunk/src/ticker.cpp

@@ -48 +48 @@
         {
             int count = 0;
-            for (Entity *e = autolist; e; e = e->autonext, count++)
+            for (Entity *e = autolist; e; e = e->m_autonext, count++)
                 ;
             Log::Error("still %i autoreleased entities\n", count);
@@ -92 +92 @@
      * ready yet, so we do not know which group this entity belongs to. Wait
      * until the first tick. */
-    entity->gamenext = data->todolist;
+    entity->m_gamenext = data->todolist;
     data->todolist = entity;
     /* Objects are autoreleased by default. Put them in a circular list. */
-    entity->autorelease = 1;
-    entity->autonext = data->autolist;
+    entity->m_autorelease = 1;
+    entity->m_autonext = data->autolist;
     data->autolist = entity;
-    entity->ref = 1;
+    entity->m_ref = 1;
 
     data->nentities++;
@@ -111 +111 @@
         return;
     }
-    if (entity->destroy)
+    if (entity->m_destroy)
         Log::Error("referencing entity scheduled for destruction\n");
 #endif
-    if (entity->autorelease)
-    {
-        /* Get the entity out of the autorelease list. This is usually
+    if (entity->m_autorelease)
+    {
+        /* Get the entity out of the m_autorelease list. This is usually
          * very fast since the first entry in autolist is the last
          * registered entity. */
         for (Entity *e = data->autolist, *prev = NULL; e;
-             prev = e, e = e->autonext)
+             prev = e, e = e->m_autonext)
         {
             if (e == entity)
             {
-                (prev ? prev->autonext : data->autolist) = e->autonext;
+                (prev ? prev->m_autonext : data->autolist) = e->m_autonext;
                 break;
             }
         }
-        entity->autorelease = 0;
+        entity->m_autorelease = 0;
     }
     else
-        entity->ref++;
+        entity->m_ref++;
 }
 
@@ -142 +142 @@
         return 0;
     }
-    if (entity->ref <= 0)
+    if (entity->m_ref <= 0)
         Log::Error("dereferencing unreferenced entity\n");
-    if (entity->autorelease)
+    if (entity->m_autorelease)
         Log::Error("dereferencing autoreleased entity\n");
 #endif
-    return --entity->ref;
+    return --entity->m_ref;
 }
 
@@ -172 +172 @@
             for (Entity *e = data->list[i]; e; )
             {
-                Log::Debug("  \\-- %s (ref %i, destroy %i)\n", e->GetName(), e->ref, e->destroy);
-                e = (i < Entity::GAMEGROUP_END) ? e->gamenext : e->drawnext;
+                Log::Debug("  \\-- %s (m_ref %i, destroy %i)\n", e->GetName(), e->m_ref, e->m_destroy);
+                e = (i < Entity::GAMEGROUP_END) ? e->m_gamenext : e->m_drawnext;
             }
         }
@@ -201 +201 @@
 
             for (int i = 0; i < Entity::ALLGROUP_END && n < data->panic; i++)
-            for (Entity *e = data->list[i]; e && n < data->panic; e = e->gamenext)
-                if (e->ref)
+            for (Entity *e = data->list[i]; e && n < data->panic; e = e->m_gamenext)
+                if (e->m_ref)
                 {
 #if !LOL_RELEASE
                     Log::Error("poking %s\n", e->GetName());
 #endif
-                    e->ref--;
+                    e->m_ref--;
                     n++;
                 }
@@ -226 +226 @@
             for (Entity *e = data->list[i], *prev = NULL; e; )
             {
-                if (e->destroy && i < Entity::GAMEGROUP_END)
+                if (e->m_destroy && i < Entity::GAMEGROUP_END)
                 {
                     /* If entity is to be destroyed, remove it from the
                      * game tick list. */
-                    (prev ? prev->gamenext : data->list[i]) = e->gamenext;
-
-                    e = e->gamenext;
+                    (prev ? prev->m_gamenext : data->list[i]) = e->m_gamenext;
+
+                    e = e->m_gamenext;
                 }
-                else if (e->destroy)
+                else if (e->m_destroy)
                 {
                     /* If entity is to be destroyed, remove it from the
                      * draw tick list and destroy it. */
-                    (prev ? prev->drawnext : data->list[i]) = e->drawnext;
+                    (prev ? prev->m_drawnext : data->list[i]) = e->m_drawnext;
 
                     Entity *tmp = e;
-                    e = e->drawnext; /* Can only be in a draw group list */
+                    e = e->m_drawnext; /* Can only be in a draw group list */
                     delete tmp;
 
@@ -248 +248 @@
                 else
                 {
-                    if (e->ref <= 0 && i >= Entity::DRAWGROUP_BEGIN)
-                        e->destroy = 1;
+                    if (e->m_ref <= 0 && i >= Entity::DRAWGROUP_BEGIN)
+                        e->m_destroy = 1;
                     prev = e;
-                    e = (i < Entity::GAMEGROUP_END) ? e->gamenext : e->drawnext;
+                    e = (i < Entity::GAMEGROUP_END) ? e->m_gamenext : e->m_drawnext;
                 }
             }
@@ -259 +259 @@
         {
             Entity *e = data->todolist;
-            data->todolist = e->gamenext;
-
-            e->gamenext = data->list[e->gamegroup];
-            data->list[e->gamegroup] = e;
-            e->drawnext = data->list[e->drawgroup];
-            data->list[e->drawgroup] = e;
+            data->todolist = e->m_gamenext;
+
+            e->m_gamenext = data->list[e->m_gamegroup];
+            data->list[e->m_gamegroup] = e;
+            e->m_drawnext = data->list[e->m_drawgroup];
+            data->list[e->m_drawgroup] = e;
         }
 
         /* Tick objects for the game loop */
         for (int i = Entity::GAMEGROUP_BEGIN; i < Entity::GAMEGROUP_END; i++)
-            for (Entity *e = data->list[i]; e; e = e->gamenext)
-                if (!e->destroy)
+            for (Entity *e = data->list[i]; e; e = e->m_gamenext)
+                if (!e->m_destroy)
                 {
 #if !LOL_RELEASE
-                    if (e->state != Entity::STATE_IDLE)
+                    if (e->m_tickstate != Entity::STATE_IDLE)
                         Log::Error("entity not idle for game tick\n");
-                    e->state = Entity::STATE_PRETICK_GAME;
+                    e->m_tickstate = Entity::STATE_PRETICK_GAME;
 #endif
                     e->TickGame(data->deltams);
 #if !LOL_RELEASE
-                    if (e->state != Entity::STATE_POSTTICK_GAME)
+                    if (e->m_tickstate != Entity::STATE_POSTTICK_GAME)
                         Log::Error("entity missed super game tick\n");
-                    e->state = Entity::STATE_IDLE;
+                    e->m_tickstate = Entity::STATE_IDLE;
 #endif
                 }
@@ -352 +352 @@
         }
 
-        for (Entity *e = data->list[i]; e; e = e->drawnext)
-            if (!e->destroy)
+        for (Entity *e = data->list[i]; e; e = e->m_drawnext)
+            if (!e->m_destroy)
             {
 #if !LOL_RELEASE
-                if (e->state != Entity::STATE_IDLE)
+                if (e->m_tickstate != Entity::STATE_IDLE)
                     Log::Error("entity not idle for draw tick\n");
-                e->state = Entity::STATE_PRETICK_DRAW;
+                e->m_tickstate = Entity::STATE_PRETICK_DRAW;
 #endif
                 e->TickDraw(data->deltams);
 #if !LOL_RELEASE
-                if (e->state != Entity::STATE_POSTTICK_DRAW)
+                if (e->m_tickstate != Entity::STATE_POSTTICK_DRAW)
                     Log::Error("entity missed super draw tick\n");
-                e->state = Entity::STATE_IDLE;
+                e->m_tickstate = Entity::STATE_IDLE;
 #endif
             }
@@ -412 +412 @@
 void Ticker::Shutdown()
 {
-    /* We're bailing out. Release all autorelease objects. */
+    /* We're bailing out. Release all m_autorelease objects. */
     while (data->autolist)
     {
-        data->autolist->ref--;
-        data->autolist = data->autolist->autonext;
+        data->autolist->m_ref--;
+        data->autolist = data->autolist->m_autonext;
     }
 

trunk/src/tileset.cpp

@@ -85 +85 @@
     data->ntiles = data->count.i * data->count.j;
 
-    drawgroup = DRAWGROUP_BEFORE;
+    m_drawgroup = DRAWGROUP_BEFORE;
 }
 

trunk/src/world.cpp

@@ -44 +44 @@
     data->height = 0;
 
-    drawgroup = DRAWGROUP_BEFORE;
+    m_drawgroup = DRAWGROUP_BEFORE;
 }