Changeset 1116Tweet

Timestamp:

Dec 23, 2011, 3:43:32 AM (11 years ago)

Author:

sam

Message:

core: fix the sign of a negative real number raised to an even power, and
add the corresponding unit test.

Location:

trunk

Files:

• src/real.cpp (modified) (1 diff)
• test/unit/real.cpp (modified) (1 diff)

trunk/src/real.cpp

@@ -693 +693 @@
     else /* x < 0 */
     {
+        /* Odd integer exponent */
+        if (y == (round(y >> 1) << 1))
+            return exp(y * log(-x));
+
+        /* Even integer exponent */
         if (y == round(y))
             return -exp(y * log(-x));
+
         /* FIXME: negative nth root */
         return real::R_0;

trunk/test/unit/real.cpp

@@ -327 +327 @@
         }
     }
+
+    LOLUNIT_TEST(Pow)
+    {
+        double a1 = pow(-real::R_2, real::R_2);
+        double b1 = 4.0;
+        LOLUNIT_ASSERT_DOUBLES_EQUAL(a1, b1, 1.0e-13);
+
+        double a2 = pow(-real::R_2, real::R_3);
+        double b2 = -8.0;
+        LOLUNIT_ASSERT_DOUBLES_EQUAL(a2, b2, 1.0e-13);
+    }
 };