Changeset 2606


Ignore:
Timestamp:
Mar 27, 2013, 1:52:19 PM (10 years ago)
Author:
sam
Message:

vslol: fix a few code quality issues.

Location:
trunk/tools/vslol
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/tools/vslol/MenuGenerateCompilers.cs

    r2123 r2606  
    22// Lol Engine - VsLol add-in for Visual Studio
    33//
    4 // Copyright: (c) 2010-2012 Sam Hocevar <sam@hocevar.net>
     4// Copyright: (c) 2010-2013 Sam Hocevar <sam@hocevar.net>
    55//   This program is free software; you can redistribute it and/or
    66//   modify it under the terms of the Do What The Fuck You Want To
     
    9191            foreach (ProjectItem item in ParseProjectItems(project))
    9292            {
    93                 if (item.Name.EndsWith("-scanner.l")
    94                      || item.Name.EndsWith("-parser.y"))
     93                if (item.Name.EndsWith("-scanner.l", StringComparison.CurrentCultureIgnoreCase)
     94                     || item.Name.EndsWith("-parser.y", StringComparison.CurrentCultureIgnoreCase))
    9595                    Visible = true;
    9696            }
     
    218218            {
    219219                Logger.Info("Error: " + executable + " exited with code " + p.ExitCode + "\n");
    220                 if (arguments != "")
     220                if (!string.IsNullOrEmpty(arguments))
    221221                    Logger.Info("Error: args: " + arguments + "\n");
    222                 if (env != "")
     222                if (!string.IsNullOrEmpty(env))
    223223                    Logger.Info("Error: env: " + env + "\n");
    224224                return false;
  • trunk/tools/vslol/VsLol.cs

    r2123 r2606  
    22// Lol Engine - VsLol add-in for Visual Studio
    33//
    4 // Copyright: (c) 2010-2012 Sam Hocevar <sam@hocevar.net>
     4// Copyright: (c) 2010-2013 Sam Hocevar <sam@hocevar.net>
    55//   This program is free software; you can redistribute it and/or
    66//   modify it under the terms of the Do What The Fuck You Want To
     
    4949    public PluginPackage()
    5050    {
    51         Trace.WriteLine(String.Format("Entering constructor for: {0}", this.ToString()));
     51        Trace.WriteLine(String.Format(CultureInfo.InvariantCulture,
     52                                      "Entering constructor for: {0}", this.ToString()));
    5253    }
    5354
     
    5657    {
    5758        // Trace the beginning of this method and call the base implementation.
    58         Trace.WriteLine(String.Format("Entering Initialize() of: {0}", this.ToString()));
     59        Trace.WriteLine(String.Format(CultureInfo.InvariantCulture,
     60                                      "Entering Initialize() of: {0}", this.ToString()));
    5961        base.Initialize();
    6062
Note: See TracChangeset for help on using the changeset viewer.