Changeset 913Tweet

Timestamp:

Sep 8, 2011, 12:21:26 AM (12 years ago)

Author:

sam

Message:

test: make LolUnit's output match CppUnit's more closely.

Location:

trunk

Files:

• src/lol/unit.h (modified) (11 diffs)
• test/lol-test.cpp (modified) (2 diffs)

trunk/src/lol/unit.h

@@ -18 +18 @@
 
 #include <iostream>
+#include <sstream>
 #include <cstdio>
 #include <cmath>
@@ -35 +36 @@
 
 protected:
-    FixtureBase() : m_next(NULL), m_tests(0), m_fails(0) {}
+    FixtureBase() : m_next(NULL), m_testcases(0), m_failcases(0) {}
     virtual ~FixtureBase() {}
 
@@ -54 +55 @@
     }
 
-    virtual int RunFixture() = 0;
+    virtual void RunFixture() = 0;
 
     /* Prevent compiler complaints about unreachable code */
@@ -60 +61 @@
 
     FixtureBase *m_next;
-    int m_tests, m_fails;
+    int m_testcases, m_failcases;
+    int m_asserts, m_failure;
+    char const *m_fixturename, *m_currentname;
+    std::stringstream m_errorlog;
 };
 
@@ -72 +76 @@
     public:
         void (FixtureClass::* m_fun)();
-        char const *m_name;
+        char const *m_testname;
         TestCase *m_next;
 
@@ -78 +82 @@
                                 void (FixtureClass::*fun)())
         {
-            that->m_name = name;
+            that->m_testname = name;
             that->m_fun = fun;
             GetOrSetTestCase(that);
@@ -90 +94 @@
 
     /* Run all test cases in this fixture. */
-    virtual int RunFixture()
-    {
-        for (TestCase *head = GetOrSetTestCase(); head; head = head->m_next)
-        {
-            (static_cast<FixtureClass *>(this)->*head->m_fun)();
-            std::cout << ".";
-        }
-        return 0;
+    virtual void RunFixture()
+    {
+        m_errorlog.str("");
+        m_testcases = 0;
+        m_failcases = 0;
+        for (TestCase *c = GetOrSetTestCase(); c; c = c->m_next)
+        {
+            m_testcases++;
+            m_asserts = 0;
+            m_failure = false;
+            m_currentname = c->m_testname;
+            (static_cast<FixtureClass *>(this)->*c->m_fun)();
+            std::cout << (m_failure ? 'F' : '.');
+        }
     }
 
@@ -118 +128 @@
 {
 public:
-    int Run()
-    {
-        int ret = 0;
-        for (FixtureBase *head = FixtureBase::GetOrSetTest(); head; head = head->m_next)
-        {
-            head->setUp();
-            if (head->RunFixture())
-                ret = 1;
-            head->tearDown();
+    bool Run()
+    {
+        bool ret = true;
+        std::stringstream errors("");
+        int failcases = 0, testcases = 0;
+
+        for (FixtureBase *f = FixtureBase::GetOrSetTest(); f; f = f->m_next)
+        {
+            f->setUp();
+            f->RunFixture();
+            f->tearDown();
+
+            errors << f->m_errorlog.str();
+            testcases += f->m_testcases;
+            failcases += f->m_failcases;
         }
         std::cout << std::endl;
+
+        std::cout << std::endl << std::endl;
+        if (failcases)
+        {
+            std::cout << "!!!FAILURES!!!" << std::endl;
+            std::cout << "Test Results:" << std::endl;
+            std::cout << "Run:  " << testcases
+                      << "  Failures: " << failcases
+                      << "  Errors: 0" << std::endl; /* TODO: handle errors */
+
+            std::cout << errors.str();
+            ret = false;
+        }
+        else
+        {
+            std::cout << "OK (" << testcases << " tests)" << std::endl;
+        }
+        std::cout << std::endl << std::endl;
+
         return ret;
     }
@@ -134 +169 @@
 
 #define LOLUNIT_FIXTURE(FixtureName) \
+    class FixtureName; \
+    static char const *LolUnitFixtureName(FixtureName *p) \
+    { \
+        (void)p; \
+        return #FixtureName; \
+    } \
     class FixtureName : public lol::Fixture<FixtureName>
 
@@ -146 +187 @@
         } \
     }; \
-    TestCase##TestCaseName test_case_##TestCaseName; \
+    TestCase##TestCaseName lol_unit_test_case_##TestCaseName; \
     void TestCaseName()
 
@@ -153 +194 @@
 
 #define LOLUNIT_ASSERT(cond) \
-    do { if (True() && !(cond)) \
-    { \
-        std::cout << "FAIL! " #cond << std::endl; \
-        return; \
-    } } while(!True())
+    do { \
+        m_asserts++; \
+        if (True() && !(cond)) \
+        { \
+            m_errorlog << std::endl << std::endl; \
+            m_errorlog << ++m_failcases << ") test: " \
+                       << LolUnitFixtureName(this) << "::" << m_currentname \
+                       << " (F) line: " << __LINE__ << " " \
+                       << __FILE__ << std::endl; \
+            m_errorlog << "assertion failed" << std::endl; \
+            m_errorlog << "- Expression: " << #cond << std::endl; \
+            m_failure = true; \
+            return; \
+        } \
+    } while(!True())
 
 #define LOLUNIT_ASSERT_EQUAL(a, b) \
-    do { if (True() && (a) != (b)) \
-    { \
-        std::cout << "FAIL! " #a " != " #b << std::endl; \
-        std::cout << "expected: " << (a) << std::endl; \
-        std::cout << "returned: " << (b) << std::endl; \
-        return; \
-    } } while(!True())
+    do { \
+        m_asserts++; \
+        if (True() && (a) != (b)) \
+        { \
+            m_errorlog << std::endl << std::endl; \
+            m_errorlog << ++m_failcases << ") test: " \
+                       << LolUnitFixtureName(this) << "::" << m_currentname \
+                       << " (F) line: " << __LINE__ << " " \
+                       << __FILE__ << std::endl; \
+            m_errorlog << "equality assertion failed" << std::endl; \
+            m_errorlog << "- Expected: " << (b) << std::endl; \
+            m_errorlog << "- Actual  : " << (a) << std::endl; \
+            m_errorlog << message; \
+            m_failure = true; \
+            return; \
+        } \
+    } while(!True())
 
 #define LOLUNIT_ASSERT_DOUBLES_EQUAL(a, b, t) \
-    do { if (True() && fabs((a) - (b)) > fabs((t))) \
-    { \
-        std::cout << "FAIL! " #a " != " #b << std::endl; \
-        std::cout << "expected: " << (a) << std::endl; \
-        std::cout << "returned: " << (b) << std::endl; \
-        return; \
-    } } while(!True())
+    do { \
+        m_asserts++; \
+        if (True() && fabs((a) - (b)) > fabs((t))) \
+        { \
+            m_errorlog << std::endl << std::endl; \
+            m_errorlog << ++m_failcases << ") test: " \
+                       << LolUnitFixtureName(this) << "::" << m_currentname \
+                       << " (F) line: " << __LINE__ << " " \
+                       << __FILE__ << std::endl; \
+            m_errorlog << "double equality assertion failed" << std::endl; \
+            m_errorlog << "- Expected: " << (b) << std::endl; \
+            m_errorlog << "- Actual  : " << (a) << std::endl; \
+            m_errorlog << "- Delta   : " << (t) << std::endl; \
+            m_failure = true; \
+            return; \
+        } \
+    } while(!True())
 
 } /* namespace lol */

trunk/test/lol-test.cpp

@@ -14 +14 @@
 
 #include <cstdio>
+#include <cstdlib>
 
 #include <lol/unit.h>
@@ -20 +21 @@
 {
     lol::TestRunner runner;
-    int ret = !runner.Run();
-    return ret;
+    bool success = runner.Run();
+    return success ? EXIT_SUCCESS : EXIT_FAILURE;
 }