Changeset 919Tweet

Timestamp:

Sep 8, 2011, 3:35:55 AM (12 years ago)

Author:

sam

Message:

lolunit: free all the memory we allocated to avoid a minor memory leak,
and slightly tweak the API syntax.

Location:

trunk

Files:

• src/lol/unit.h (modified) (6 diffs)
• test/lol-test.cpp (modified) (1 diff)

trunk/src/lol/unit.h

@@ -29 +29 @@
 class FixtureBase
 {
-    friend class TestRunner;
+    friend class TextTestRunner;
 
 public:
@@ -55 +55 @@
     }
 
-    virtual void RunFixture() = 0;
+    virtual void runFixture() = 0;
 
     /* Prevent compiler complaints about unreachable code */
@@ -94 +94 @@
 
     /* Run all test cases in this fixture. */
-    virtual void RunFixture()
+    virtual void runFixture()
     {
         m_errorlog.str("");
@@ -125 +125 @@
 };
 
-class TestRunner
+class TextTestRunner
 {
 public:
-    bool Run()
+    bool run()
     {
         bool ret = true;
@@ -137 +137 @@
         {
             f->setUp();
-            f->RunFixture();
+            f->runFixture();
             f->tearDown();
 
@@ -172 +172 @@
     template<typename T> struct Make##FixtureName \
     { \
-        Make##FixtureName() { new T(); } \
+        Make##FixtureName() { p = new T(); } \
+        ~Make##FixtureName() { delete p; } \
+        T *p; \
     }; \
     Make##FixtureName<FixtureName> lol_unit_fixture_##FixtureName; \

trunk/test/lol-test.cpp

@@ -20 +20 @@
 int main(void)
 {
-    lol::TestRunner runner;
-    bool success = runner.Run();
+    lol::TextTestRunner runner;
+    bool success = runner.run();
     return success ? EXIT_SUCCESS : EXIT_FAILURE;
 }