Changeset 925Tweet

Timestamp:

Sep 8, 2011, 9:18:31 AM (12 years ago)

Author:

sam

Message:

lolunit: reverse the expected/actual logic.

CPPUNIT_ASSERT_EQUAL(a, b) “expects” the value “a” and fails if “b” is
different. The logic seems backwards to me, but matching CppUnit’s
output is important so I’m doing the same in LolUnit.

File:

• trunk/src/lol/unit.h (modified) (2 diffs)

trunk/src/lol/unit.h

@@ -227 +227 @@
                        << __FILE__ << std::endl; \
             m_errorlog << "equality assertion failed" << std::endl; \
-            m_errorlog << "- Expected: " << (b) << std::endl; \
-            m_errorlog << "- Actual  : " << (a) << std::endl; \
+            m_errorlog << "- Expected: " << (a) << std::endl; \
+            m_errorlog << "- Actual  : " << (b) << std::endl; \
             m_errorlog << message; \
             m_failure = true; \
@@ -246 +246 @@
                        << __FILE__ << std::endl; \
             m_errorlog << "double equality assertion failed" << std::endl; \
-            m_errorlog << "- Expected: " << (b) << std::endl; \
-            m_errorlog << "- Actual  : " << (a) << std::endl; \
+            m_errorlog << "- Expected: " << (a) << std::endl; \
+            m_errorlog << "- Actual  : " << (b) << std::endl; \
             m_errorlog << "- Delta   : " << (t) << std::endl; \
             m_errorlog << message; \